Fix symbol IDs assigned to encoding packets #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cberner
reviewed
Mar 9, 2024
Previously, we incorrectly assigned internal symbol IDs (ISIs) to the `PayloadId` of `EncodingPacket`s. According to RFC 6330, it should be the encoding symbol IDs (ESIs). This commit fixes this inconsistency. BREAKING CHANGE: As the assignment of symbol IDs changes, encoding packets generated before this change cannot be decoded by the new version and vice-versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we incorrectly assigned internal symbol IDs (ISIs) to the
PayloadIdofEncodingPackets. According to RFC 6330, it should be the encoding symbol IDs (ESIs). This commit fixes this inconsistency.BREAKING CHANGE: As the assignment of symbol IDs changes, encoding packets generated before this change cannot be decoded by the new version and vice-versa.
Closes #164